-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NPE during ova import #773
Conversation
Signed-off-by: Shubha Kulkarni <shubha.kulkarni@oracle.com>
472ff95
to
e9b5c61
Compare
/ost |
I see that OST is canceled. How do make sure this runs or fixed? |
huh, no idea. there ahs been some connectivity issues today. let me try again |
/ost |
there seem to be a bug in the check...let me take a look |
not a bug, arik's fault. for non-members of ovirt organization the exact commit to run needs to be approved. but the last force push invalidated the approval. |
@ahadas please avoid approving and rebasing, do it the other way around please |
/ost |
it feels like you give me a car that cannot turn left and say "please avoid turning left, go only straight and right" :) |
...or fix your car. Patches are welcome.
no, protection of our build infrastructure so that we do not run random code from malicious PRs. |
Yes, but that was needed when we thought about that automatic gating - OST would run automatically on the PR and once it passes and the PR gets approved, it would be merged by some github action.. now that we trigger OST manually and only people that are part of the oVirt org can do that, it's not an issue, no? |
it still is |
I'm afraid I'll need more information on this if you really welcome patches to address this issue :) Anyway, let's get this PR in |
Title - Fix NPE during ova import
Issue - During ova import, if event node is null, engine log has error as well as NPE
Fix - Check eventNode for the null value
Signed-off-by: Shubha Kulkarni shubha.kulkarni@oracle.com